Skip to content

feat: Expose apify_client.errors module - #468

Merged
vdusek merged 3 commits into
apify:masterfrom
Mantisus:public-errors
Aug 13, 2025
Merged

vdusek merged 3 commits into
apify:masterfrom
Mantisus:public-errors

Conversation

@Mantisus

Copy link
Copy Markdown
Collaborator
  • Move apify_client._errors to apify_client.errors

Issues

@Mantisus
Mantisus requested review from Pijukatel and vdusek August 13, 2025 09:14
@Mantisus Mantisus self-assigned this Aug 13, 2025
@Mantisus
Mantisus had a problem deploying to fork-pr-integration-tests August 13, 2025 09:15 — with GitHub Actions Failure
@vdusek vdusek changed the title refactor!: Move apify_client._errors to apify_client.errors feat: Expose apify_client.errors module Aug 13, 2025

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but please let's move is_retryable_error function to _utils as this should probably stay private.

@Mantisus
Mantisus requested a review from vdusek August 13, 2025 09:37

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what about httpx here? I believe it should be impit and its errors.

@Mantisus
Mantisus had a problem deploying to fork-pr-integration-tests August 13, 2025 11:33 — with GitHub Actions Failure
@Mantisus

Copy link
Copy Markdown
Collaborator Author

Also, what about httpx here? I believe it should be impit and its errors.

That's right, but when I was preparing the PR, we hadn't merged the PR with impit yet. Updated :)

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek
vdusek merged commit c0cc147 into apify:master Aug 13, 2025

This branch had an error being deployed

1 failed deployment
fork-pr-integration-tests — 9b4fb4e1 Deployed Aug 13, 2025 by Mantisus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move apify_client._errors to apify_client.errors

2 participants